Ezgi-Gunes-JavaScript-Core-1-Coursework-Week3-London8 by Ezgi3406 · Pull Request #27 · CodeYourFuture/JavaScript-Core-1-Coursework-Week3

Ezgi3406 · 2022-01-13T21:52:06Z

No description provided.

hachi-ops

Hi Ezgi, I reviewed your 'exercises' folder. Hope you'll find it helpful:)

hachi-ops · 2022-01-14T10:30:47Z

+        even.push(i);
+        i+=2;
+
+    }return even;


The final output is correct except it should return a string. Think of a method that allows you to do that.

hachi-ops · 2022-01-14T10:47:31Z

-function findFirstJulyBDay(birthdays) {
-    // TODO
-}
+const findFirstJulyBDay = BIRTHDAYS.find(e=>e.includes('July'));


The console displays an error message saying it is not a function. There might be some syntax problems here.

hachi-ops · 2022-01-14T10:59:45Z

+      startNumber++;
+    } while (startNumber < n);
+    return sum;
+  }


Your code would work if you placed your changes inside the function.

The code does work :) Maybe it looked confusing on a github diff?

hachi-ops · 2022-01-14T11:13:43Z

-let i = 0;
-while(i < 26) {
+
+for(let i = 0; i < 26; i++) {


hachi-ops · 2022-01-14T11:18:10Z

 // TODO - Write for loop code here
+for (var i = 0; i < WRITERS.length; i++) {
+
+    console.log(`${WRITERS[i]} is ${AGES[i]} years old.`)


Good use of template literals.

hachi-ops · 2022-01-14T11:21:51Z

 ];
+for(let element of tubeStations){
+
+    console.log(element);


Good but get rid of the unnecessary spaces:)

hachi-ops · 2022-01-14T11:31:16Z

 // TODO Use a for-of loop to capitalise and output each letter in the string seperately.
 let str = "codeyourfuture";
+for(let element of str){
+    const myArr=str.toUpperCase().split('');


I think you should target 'element' here not 'str'. The aim of this exercise is to output each letter separately, not the whole string. Also, I don't think you need split method here because it unnecessarily converts you string back to an array.

jstadnik

Congratulations on completing all the exercises!

You pulled a little ahead of the class -- these exercises were about loops, while you used a number of array methods and anonymous functions. It's not incorrect, but you may want to be mindful about making sure you do know how to use for/while loops when you need to.

You should be mindful of two "presentation" issues:

indentation -- in a number of places you indented things inconsistently/wrongly. I haven't pointed them all out, but I can, if that's helpful. Are you using any auto-formatter in your IDE, such as prettier?
leftover debug code -- make sure you remove print (console.log) statements you used for debugging before you submit your PR.

On the whole, though, I am very impressed! Great job! 🙂

jstadnik · 2022-01-16T18:12:13Z

-evenNumbers(0); // should output nothing
-evenNumbers(10); // should output 0,2,4,6,8,10,12,14,16,18
+
+console.log(evenNumbers(3)); // should output 0,2,4


So, technically, according to the instructions, the function should console.log things.

jstadnik · 2022-01-16T18:12:30Z

+    let even=[]
+    let i =0
+
+    while(even.length<n){


jstadnik · 2022-01-16T18:41:20Z

-function findFirstJulyBDay(birthdays) {
-    // TODO
-}
+const findFirstJulyBDay = BIRTHDAYS.find(e=>e.includes('July'));


While this is a clever solution and kind of does solve the problem, you should try and implement things as asked by the exercise, rather than modify the check. So, here for example, you could do

function findFirstJulyBDay(birthdays) { return birthdays.find(e=>e.includes('July')); }

To create a function.

Also, this should technically be a "while" loop exercise -- how would you complete it with a while loop?

jstadnik · 2022-01-16T18:44:31Z

+      startNumber++;
+    } while (startNumber < n);
+    return sum;
+  }


The code does work :) Maybe it looked confusing on a github diff?

jstadnik · 2022-01-16T18:45:09Z

+    let startNumber = 0;
+    let sum = 0;
+    do {
+      sum += startNumber * 2;


jstadnik · 2022-01-16T19:14:48Z

+    let totalCharacterNumber = 0;
+  for (let i = 0; i < allArticleTitles.length; i++) {
+    totalCharacterNumber =
+      totalCharacterNumber + allArticleTitles[i].split("").length;


.length works on strings, too:

> str = "somestr" 'somestr' > str.length 7

jstadnik · 2022-01-16T19:19:09Z

+            }
+            average = parseFloat((sum/counter).toFixed(2))
+
+            console.log(average);


You should try and remove all console.log you used for debugging before your final submission.

jstadnik · 2022-01-16T19:20:59Z

+
+    for(let price of closingPricesForAllStocks){
+
+        let priceDiff=Number(price[price.length-1]-price[0])


Is Number needed here?

jstadnik · 2022-01-16T19:34:08Z

    // TODO
+    let bookTitles=[];
+    for(let i=0; i<books.length; i++){
+        if(books[i].rating > 4.8){


This works for the exact test case provided, but wouldn't work with different inputs (for instance, if a genre's highest-rated book was rated 4.5), or there were two books rated > 4.8 in one genre.

jstadnik · 2022-01-16T19:35:14Z

    // TODO
+
+    let fibonacci = [0, 1];
+    for(i = 2; i < n; i++) {


Great work on this one!

Assighment comleted

8b9da5f

hachi-ops reviewed Jan 14, 2022

View reviewed changes

jstadnik reviewed Jan 16, 2022

View reviewed changes

jstadnik added the reviewed A mentor has reviewed this code label Jan 16, 2022


		for(let price of closingPricesForAllStocks){

		let priceDiff=Number(price[price.length-1]-price[0])

Uh oh!

Uh oh!

Conversation

Ezgi3406 commented Jan 13, 2022

Uh oh!

hachi-ops left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jstadnik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants