This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London10--Kristina Dudnyk--JS--Week3 - #250
Open
KristinaDudnyk wants to merge 3 commits into
Open
Conversation
AnnaFYZ
reviewed
Mar 15, 2023
AnnaFYZ
left a comment
There was a problem hiding this comment.
Now i see why there are no other comments :) because it is minimum one step higher from our level, ha ha ha
Awesome :) 👍
| @@ -12,52 +12,47 @@ | |||
| */ | |||
|
|
|||
| function getTemperatureReport(cities) { | |||
| @@ -5,7 +5,9 @@ | |||
| Implement the function below, which will return a new array containing only article titles which will fit. | |||
| */ | |||
| @@ -14,7 +16,7 @@ function potentialHeadlines(allArticleTitles) { | |||
| (you can assume words will always be seperated by a space) | |||
| */ | |||
Contributor
There was a problem hiding this comment.
This is a very good attempt - but there's one small problem.
Your code returns the title with the fewest characters... But for this exercise, we would like the title with the fewest words 😄
Can you think of how you can change your code to achieve this?
| @@ -23,59 +25,71 @@ function titleWithFewestWords(allArticleTitles) { | |||
| (Hint: remember that you can also loop through the characters of a string if you need to) | |||
| */ | |||
| @@ -34,9 +34,15 @@ const CLOSING_PRICES_LAST_5_DAYS_FOR_ALL_STOCKS = [ | |||
| Functions can help with this! | |||
| */ | |||
| @@ -14,24 +14,42 @@ | |||
| */ | |||
|
|
|||
Contributor
|
Amazing job @KristinaDudnyk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.