Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Tosin Odunuga-JS1-Week3 - #228

Open
fowobi wants to merge 4 commits into
CodeYourFuture:mainfrom
fowobi:main
Open

Tosin Odunuga-JS1-Week3#228
fowobi wants to merge 4 commits into
CodeYourFuture:mainfrom
fowobi:main

Conversation

@fowobi

@fowobi fowobi commented Mar 4, 2023

Copy link
Copy Markdown

Glasgow Class 6
Tosin odunuga
JS 1
Week 3

fowobi added 4 commits March 3, 2023 21:36
Mandatory done
Exercise done
Extra Answered
Answer the Undefined exercise

@Muath-Alawadhi Muath-Alawadhi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#####Well done #####

}
return reports;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work !

}

return headlines;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's a good way to use ! sNaN I really didn't know about it


for (const title of allArticleTitles) {
for (const character of title) {
if (!isNaN(parseInt(character))) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea using the !isNaN!

Comment thread 2-mandatory/3-stocks.js

return descriptions;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the Math.max. I hadn't heard of it before!

@fowobi fowobi added the review requested I would like a mentor to review my PR label Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

review requested I would like a mentor to review my PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants