This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 6 - Appolin Semegni Fotso - JavaScript - Week 3 - #224
Open
AppolinFotso wants to merge 3 commits into
Open
Glasgow Class 6 - Appolin Semegni Fotso - JavaScript - Week 3#224AppolinFotso wants to merge 3 commits into
AppolinFotso wants to merge 3 commits into
Conversation
ManSangSin
reviewed
Mar 13, 2023
Comment on lines
+28
to
+37
| for (let title of allArticleTitles) { | ||
| titleLength.push(title.length); | ||
| } | ||
|
|
||
| let miniTitle = Math.min(...titleLength); | ||
|
|
||
| for (let title of allArticleTitles) | ||
| if (title.length == miniTitle) { | ||
| return title; | ||
| } |
There was a problem hiding this comment.
Well done @AppolinFotso. Very cool and clean method to find shortest title. I also just learned of the triple dot operator from your code, looks very useful thank you!
Author
There was a problem hiding this comment.
Thank you @ManSangSin! I also learned a lot from your codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.