This repository was archived by the owner on Jan 14, 2024. It is now read-only.
LONDON CLASS 8 - BERKELI HALMYRADOV - JS CORE 1 - WEEK 3 - #2
Open
berkeli wants to merge 5 commits into
Open
Conversation
gixo
approved these changes
Jan 10, 2022
gixo
left a comment
There was a problem hiding this comment.
Well done overall, this was an excellent submission and I only raised minor points:
- watch out for typos and grammatical errors
- install a linter to check the static correctness of your code
- use more meaningful variable names
- try to solve the same problem in as many ways as possible, to experiment with different approaches
You are on a great path!
|
Nice, looks good! 👍 |
|
Hi Berkeli, very nice and sleek code. |
jacint-david
left a comment
There was a problem hiding this comment.
Impressive Berkeli! 🎉 You pick your data structures and methods wisely! 👍 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gixo homework for this week