This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London9 Lovelace - Mehreen Aziz - JS Week 3 - #194
Open
Mehreenaziz wants to merge 3 commits into
Open
Conversation
rami1207
reviewed
Dec 20, 2022
| do { | ||
| i = i + 1; | ||
|
|
||
| if (i % 2 === 0) { |
rami1207
reviewed
Dec 20, 2022
| function getTemperatureReport(cities) { | ||
| // TODO | ||
| let cityWeather = []; | ||
| for (let i = 0; i < cities.length; i++) { |
There was a problem hiding this comment.
Perhaps linting could be applied here
rami1207
reviewed
Dec 20, 2022
| function headlinesWithNumbers(allArticleTitles) { | ||
| // TODO | ||
| // let arrayNum = [] | ||
| // for (let el of ARTICLE_TITLES) { |
There was a problem hiding this comment.
Removing the dead code would enhance the readability and accidental issues
rami1207
reviewed
Dec 20, 2022
rami1207
left a comment
There was a problem hiding this comment.
Highly commendable work. Keep it up. Pay attention to the dead code and lining. Apart from that, they are perfect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.