Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London 9 - Oleh Pysmenko - JavaScript Core 1 - Week 3 - #166

Open
tiritaki wants to merge 5 commits into
CodeYourFuture:mainfrom
tiritaki:main
Open

London 9 - Oleh Pysmenko - JavaScript Core 1 - Week 3#166
tiritaki wants to merge 5 commits into
CodeYourFuture:mainfrom
tiritaki:main

Conversation

@tiritaki

@tiritaki tiritaki commented Dec 4, 2022

Copy link
Copy Markdown

No description provided.

@tiritaki

tiritaki commented Dec 4, 2022

Copy link
Copy Markdown
Author

Your Details
Your Name: Oleh Pysmenko
Your City: London
Your Slack Name: tiritaki
Homework Details
Module: JavaScript Core 1
Week: 3
Notes
What did you find easy?

What did you find hard?

What do you still not understand?

Any other notes?

Comment thread 2-mandatory/1-weather-report.js Outdated
Comment thread 2-mandatory/3-financial-times.js Outdated
Comment thread 2-mandatory/3-financial-times.js Outdated
Comment thread 2-mandatory/4-stocks.js Outdated
@tiritaki

tiritaki commented Dec 5, 2022

Copy link
Copy Markdown
Author

Hi @nuclear-pasta.
Could you pls look into 2-array-of-objects.js in extra folder.
There should be better approach.

@nuclear-pasta

Copy link
Copy Markdown

Hi @nuclear-pasta. Could you pls look into 2-array-of-objects.js in extra folder. There should be better approach.

I will give a check after 6pm

Comment thread 3-extra/2-array-of-objects.js
}

}
return [nameChil, nameNon, nameCook]

@nuclear-pasta nuclear-pasta Dec 12, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can rewrite this function without the need to declare the genre, and in a single loop.
what if you register an empty object before the loop, and every time there is a new genre, you register that genre as the key of the object, and as value, you register the rating (highest rating but at the first loop will be whatever rating). This will save you from new genre non considered in your code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants