NW5/Kamran-Nikkhah/JavaScript-Core-1-Coursework-Week3 - #146

Thanks for your JS week 3 pull request.

All your mandatory tests pass - TDD is a great way to write code. Gives confidence. Just some minor details really about comments. So remember if there is a comment// TODOad you implemented the code then remove the comment. It helps other people in your team to see what things they need to look at just by scanning through code.

Also take care with indentation. Again it helps others reading and understanding your code.

One technical point in 3-financial-times.js - how robust is the function isNumber(char) ? For production code your manager will ask what happens if it is called with an object say isNumber({}); Not a criticism here - this is a good submission but more to think about how robust your code is to failure.

One last thing - in your B-while-loop exercise the evenNumbers function works with strings. Well that seems OK - we need to output a string. But often you will hear about separation of concerns. Think about working with numbers to build an array of even numbers. That's one concern - a pure calculation. Then think about how to display the output. That is a second concern. If you change how you want the output you don't need to change the pure calculation. It's an important design skill.

Thanks again though for your work here.

Steve