Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Leeds_ Shimaadnan_JavaScript_Core1_week3 #129

Open
Shimaadnan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Leeds_ Shimaadnan_JavaScript_Core1_week3 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa5b9d
exercices
Shimaadnan Sep 19, 2022
bfd237d
Mandatory & extar 1 and3
Shimaadnan Sep 20, 2022
c7fe11f
Working on th second and Last MAn questions
Shimaadnan Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions 1-exercises/A-undefined/exercise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,26 @@
// Example 1
let a;
console.log(a);

// Because the value of a is not defined.

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on Shima 👍


// Example 2
function sayHello() {
let message = "Hello";
let message = "Hello";
}

let hello = sayHello();
console.log(hello);

// We have not define any return or outcome for our function.

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great answer, absolutely correct.


// Example 3
function sayHelloToUser(user) {
console.log(`Hello ${user}`);
console.log(`Hello ${user}`);
}

sayHelloToUser();

// We have not define anything for our "user " argument.

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant 👍


// Example 4
let arr = [1,2,3];
let arr = [1, 2, 3];
console.log(arr[3]);
// This index is not defined.
12 changes: 11 additions & 1 deletion 1-exercises/B-while-loop/exercise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,18 @@
*/

function evenNumbers(n) {
// TODO
let evenNum = [];
let i = 0;
let even = 0;
while (i < n) {

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great.

Do you think we could improve this using the modulo operator? (%)?

if (n % 2 === 0) {
  evenNumber.push(n);
}

@Shimaadnan Shimaadnan Oct 6, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me.
In the question we have been ask to do with while loop

evenNum.push(even);
even += 2;
i = i + 1;
}
return evenNum;
// TODO
}
console.log(evenNumbers(6));

evenNumbers(3); // should output 0,2,4
evenNumbers(0); // should output nothing
Expand Down
27 changes: 17 additions & 10 deletions 1-exercises/C-while-loop-with-array/exercise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,26 @@
*/

const BIRTHDAYS = [
"January 7th",
"February 12th",
"April 3rd",
"April 5th",
"May 3rd",
"July 11th",
"July 17th",
"September 28th",
"November 15th"
"January 7th",
"February 12th",
"April 3rd",
"April 5th",
"May 3rd",
"July 11th",
"July 17th",
"September 28th",
"November 15th",
];

function findFirstJulyBDay(birthdays) {
// TODO
let i = 0;
while (i < birthdays.length) {
if (birthdays[i].includes("July")) {

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does work because our array is in order, what do you think will happen if I moved "July 17th" to the top of our const BIRTHDAYS = [] array?

return birthdays[i];
}
i++;
}
// TODO

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a good idea to remove inline comments unless absolutely necessary :)

}

console.log(findFirstJulyBDay(BIRTHDAYS)); // should output "July 11th"
13 changes: 11 additions & 2 deletions 1-exercises/D-do-while/exercise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,18 @@
*/

function evenNumbersSum(n) {
// TODO
let sum = 0;
let i = 0;
even = 0;
do {
sum = sum + even;
even += 2;
i++;
} while (i < n);
return sum;
// TODO
}

console.log(evenNumbersSum(3)); // should output 6
console.log(evenNumbersSum(0)); // should output 0
console.log(evenNumbersSum(10)); // should output 90
console.log(evenNumbersSum(10)); // should output 90
12 changes: 7 additions & 5 deletions 1-exercises/E-for-loop/exercise1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
Change the while loop below into a for loop.
*/


// Change the below code to use a for loop instead of a while loop.
let i = 0;
while(i < 26) {
console.log(String.fromCharCode(97 + i));
i++;
// let i = 0;
// while (i < 26) {
// console.log(String.fromCharCode(97 + i));
// i++;
// }
for (let i = 0; i < 26; i++) {

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Shima, just a reminder that commented out code is sometimes best deleted before committing. We have a section on it in CYF here

https://syllabus.codeyourfuture.io/guides/code-style-guide#dont-leave-lots-of-commented-out-code

console.log(String.fromCharCode(97 + i));
}
// The output shouldn't change.
22 changes: 9 additions & 13 deletions 1-exercises/E-for-loop/exercise2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,17 @@
*/

const WRITERS = [
"Virginia Woolf",
"Zadie Smith",
"Jane Austen",
"Bell Hooks",
"Yukiko Motoya"
]

const AGES = [
59,
40,
41,
63,
49
"Virginia Woolf",
"Zadie Smith",
"Jane Austen",
"Bell Hooks",
"Yukiko Motoya",
];

const AGES = [59, 40, 41, 63, 49];
for (let i = 0; i < 5; i++) {

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you did works great here, but what happens if I add "Stephen Speakman" to the bottom of the WRITERS array and 34 to the bottom of the AGES array?

I would not be output because you only use i < 5 - it'd be better to use length with this one 👍

console.log(`${WRITERS[i]} is ${AGES[i]} years old`);
}
// TODO - Write for loop code here

/*
Expand Down
18 changes: 12 additions & 6 deletions 1-exercises/F-for-of-loop/exercise.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,19 @@

// TODO Use a for-of loop to output each of the tube stations below.
let tubeStations = [
"Aldgate",
"Baker Street",
"Picadilly Circus",
"Oxford Street",
"Tottenham Court Road"
"Aldgate",
"Baker Street",
"Picadilly Circus",
"Oxford Street",
"Tottenham Court Road",
];

for (const element of tubeStations) {
console.log(element);
}

// TODO Use a for-of loop to capitalise and output each letter in the string seperately.
let str = "codeyourfuture";
for (const letters of str) {

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on! My only feedback would be to rename letters to letter since it's a little misleading. The const letter variable will only hold one character each loop so it should be singular.

I need to double check if this would be better as a let instead of a const.

let upperCase = letters.toUpperCase();
console.log(upperCase);
}
70 changes: 35 additions & 35 deletions 2-mandatory/1-weather-report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,52 +12,52 @@
*/

function getTemperatureReport(cities) {
// TODO
arr = [];
for (let city of cities) {
arr = arr.push(

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use arr = here because arr.push modifies the existing arr variable. If you recall when we spoke in our slack group the other day, pop also does the same. They modify existing variables, they do not return a new array.

.push() actually returns the new length of the array. Imagine this example:

let hawkTraineeGroup = ['Stephen', 'Ekrem', 'Cuneyt', 'Waheed'];

console.log(hawkTraineeGroup);  // This will output Stephen, Ekrem, Cuneyt, Waheed

const newGroup = hawkTraineeGroup.push('Shima');

console.log(newGroup); // This will output 5, since "push()` returns the new length
console.log(hawkTraineeGroup); // This will output an array with all 5 of us in it - Stephen, Ekrem, Cuneyt, Waheed and Shima

So push modifies the existing array, but returns its new length.

`The tempreture in ${city} is ${temperatureService(city)} degrees,`
);
}
return arr;

// TODO
}


/* ======= TESTS - DO NOT MODIFY ===== */

function temperatureService(city) {
let temparatureMap = new Map();

temparatureMap.set('London', 10);
temparatureMap.set('Paris', 12);
temparatureMap.set('Barcelona', 17);
temparatureMap.set('Dubai', 27);
temparatureMap.set('Mumbai', 29);
temparatureMap.set('São Paulo', 23);
temparatureMap.set('Lagos', 33);
return temparatureMap.get(city);
let temparatureMap = new Map();

temparatureMap.set("London", 10);
temparatureMap.set("Paris", 12);
temparatureMap.set("Barcelona", 17);
temparatureMap.set("Dubai", 27);
temparatureMap.set("Mumbai", 29);
temparatureMap.set("São Paulo", 23);
temparatureMap.set("Lagos", 33);

return temparatureMap.get(city);
}

test("should return a temperature report for the user's cities", () => {
let usersCities = [
"London",
"Paris",
"São Paulo"
]

expect(getTemperatureReport(usersCities)).toEqual([
"The temperature in London is 10 degrees",
"The temperature in Paris is 12 degrees",
"The temperature in São Paulo is 23 degrees"
]);
let usersCities = ["London", "Paris", "São Paulo"];

expect(getTemperatureReport(usersCities)).toEqual([
"The temperature in London is 10 degrees",
"The temperature in Paris is 12 degrees",
"The temperature in São Paulo is 23 degrees",
]);
});

test("should return a temperature report for the user's cities (alternate input)", () => {
let usersCities = [
"Barcelona",
"Dubai"
]

expect(getTemperatureReport(usersCities)).toEqual([
"The temperature in Barcelona is 17 degrees",
"The temperature in Dubai is 27 degrees"
]);
let usersCities = ["Barcelona", "Dubai"];

expect(getTemperatureReport(usersCities)).toEqual([
"The temperature in Barcelona is 17 degrees",
"The temperature in Dubai is 27 degrees",
]);
});

test("should return an empty array if the user hasn't selected any cities", () => {
expect(getTemperatureReport([])).toEqual([]);
});
expect(getTemperatureReport([])).toEqual([]);
});
22 changes: 14 additions & 8 deletions 2-mandatory/2-retrying-random-numbers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,26 @@

// This function shouldn't be changed
function generateRandomNumber() {
console.log("Generating number...");
return Math.round(Math.random() * 100);
console.log("Generating number...");
return Math.round(Math.random() * 100);
}

function getRandomNumberGreaterThan50() {
// TODO - implement using a do-while loop
let number = 0;
do {
return (number = getRandomNumberGreaterThan50());

@Gevie Gevie Oct 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a little bit of a problem with this function, you're calling the function you are within, rather than calling generateRandomNumber()

So if we run through it...
Number is equal to zero
Whilst number is less than or equal to 50, call the function which defines number as zero and assign that as number.

It's an infinite loop, unless I am missing something.

} while (number <= 50);

// TODO - implement using a do-while loop
return number;
}

/* ======= TESTS - DO NOT MODIFY ===== */

test("Returned value should always be greater than 50", () => {
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
expect(getRandomNumberGreaterThan50()).toBeGreaterThan(50);
});
Loading