MANCHESTER CLASS_NW5 - ANVAR AZIZI - MODULE - javaScript-Core-1-Week3 by rebwar1 · Pull Request #125 · CodeYourFuture/JavaScript-Core-1-Coursework-Week3

rebwar1 · 2022-09-20T02:52:52Z

No description provided.

KarenPudner · 2022-09-21T19:39:32Z

-let arr = [1,2,3];
-console.log(arr[3]);
+let arr = [1, 2, 3];
+console.log(arr[3]); // return undefined because the value has not been assigned in index 3


Good - you have answered all of these correctly.

KarenPudner · 2022-09-21T19:47:03Z

+    let result = [];
+    if (n) {
+        while (count < n) {
+            count === 0 ? result.push(count) : result.push(count * 2);


This works well - you don't need to do the check, you can just use result.push(count * 2) as 0x2=0.

KarenPudner · 2022-09-21T19:55:34Z

+
+    while (count < birthdays.length) {
+        if (birthdays[count].split(" ")[0] === "July") {
+            july.push(birthdays[count]);


Good use of split and index here. You could also use "break" to exit the while loop once you have found the first July date.

KarenPudner · 2022-09-21T20:05:59Z

 console.log(evenNumbersSum(0)); // should output 0
-console.log(evenNumbersSum(10)); // should output 90
+// console.log(evenNumbersSum());
+console.log(evenNumbersSum(10)); // should output 90


You need to re-read the question. You need the loop to add up the first n even numbers, starting at 0. So if n=3, you need to add up 0+2+4. If n=10 you need to add up 0+2+4+6+8+10+12+14+16+18.

KarenPudner · 2022-09-21T20:10:24Z

+
+for (let i = 0; i < 26; i++) {
+    console.log(String.fromCharCode(65 + i), String.fromCharCode(97 + i));
+}


Good work - adding upper case letters wasn't necessary, but it's good to see that you are interested in how fromCharCode works.

KarenPudner · 2022-09-21T20:12:37Z

+// TODO - Write for loop code here
+for (let i = 0; i < WRITERS.length; i++) {
+    console.log(`${WRITERS[i]} is ${AGES[i]} years old`);
+}


Yes, good use of the loop index for both arrays.

KarenPudner · 2022-09-21T20:15:23Z

+    console.log(letter.toUpperCase());
+}
+console.log("_____________________");
+console.log(capitalise);


Good you have clearly understood how to use a for loop on an array.

KarenPudner · 2022-09-21T20:32:23Z

+    let city = temperatureService;
+    let statementTempCity = cities.map(
+        (element) => `The temperature in ${element} is ${city(element)} degrees`
+    );


Yes, this is very efficient.

KarenPudner · 2022-09-21T20:45:04Z

+        }

+        i--;
+    } while (i > 50);


This will exit after 50 loops, so it might not always find a number over 50. But I also understand why you want it to exit so that you don't end up with an endless loop if your logic is wrong.

KarenPudner · 2022-09-21T20:46:34Z

-    // TODO
+    let arrLingth65 = allArticleTitles.filter(
+        (item) => item.split("").length <= 65
+    );


Good use of split.

KarenPudner · 2022-09-21T20:51:10Z

+    let arrLingth65 = allArticleTitles.filter(
+        (item) => item.split("").length <= 65
+    );
+    return arrLingth65[arrLingth65.length - 1];


This logic returns the last headline in ARTICLE_TITLES which has 65 characters or less - by co-incidence this is also the headline with the fewest words so your test passes. But if the order of ARTICLE_TITLES is changed, the test will fail. If you have time, try to re-implement this with the correct logic.

KarenPudner · 2022-09-21T20:52:15Z

 function headlinesWithNumbers(allArticleTitles) {
-    // TODO
+    let semple = /\d+/;
+    let findNum = allArticleTitles.filter((item) => item.match(semple));


Good use of regex.

KarenPudner · 2022-09-21T20:54:19Z

 function averageNumberOfCharacters(allArticleTitles) {
-    // TODO
+    // let everage = allArticleTitles.map(el=>el.length)
+    let average = allArticleTitles.join("").length / allArticleTitles.length;


Good use of join with an empty string.

KarenPudner · 2022-09-21T21:14:12Z

-    // TODO
+    let capitalisedSTocks = stocks.map((el) => el.toUpperCase());
+    let highestPrice = closingPricesForAllStocks.map((el) =>
+        Math.max(...el).toFixed(2)


Good use of spread - this is advanced knowledge.

KarenPudner · 2022-09-21T21:36:49Z

+                el.reduce((acc, value, _, { length }) => {
+                    // console.log(length);
+                    return acc + value;
+                }) / el.length


Good use of reduce - this is advanced knowledge. I'm not sure what "_, { length } "does here - the code seems to work without it. You can explain it to me when we meet next week.

KarenPudner · 2022-09-22T15:51:48Z

+    let result = 1;
+    for (let i = 1; i <= input; i++) {
+        result *= i;
+    }


Good concise code.

KarenPudner · 2022-09-22T16:00:21Z

+    let cooking = operation(books, "cooking");
+    const result = [children, non_fiction, cooking];
+    return result;
+}


Your functions could have more descriptive names. Also, think about how you might get the list of genres from the array of objects rather than having to hard code it. Don't feel you have to redo this - it's a difficult, stretch exercise and your method is understandable and works well - it's just something to think about.

KarenPudner · 2022-09-22T16:02:57Z

+    }

+    return result;
+}


Excellent - this is clear concise code and works well.

KarenPudner

Great work! There are a few minor things to look at in my comments, but you have covered a lot of material this week and have clearly understood all the concepts.

while loop once you have found the first July date

rebwar1 added 14 commits September 18, 2022 05:53

1-exercises A-undefined

852b66f

1-exercises__ B-while-loop B-while-loop

4264d55

1-exercises__C-while-loop-with-array

a5ebd8e

1-exercises__D-do-while

c6ecc03

1-exercises__E-for-loop

50d97c5

1-exercises__F-for-of-loop

1335e3c

2-mandatory__1-weather-report

f4c1c94

2-mandatory__1-weather-report__3-financial-times

af2a5d4

2-mandatory__2-retrying-random-numbers

7d6c811

delet for loop in mandatory__2-retrying-random

1176b91

2-mandatory__4-stocks

e759f64

3-extra/1-factorial.js

c4c861d

3-extra/2-array-of-objects.js

be41cb1

3-extra/3-fibonacci.js

810384c

KarenPudner reviewed Sep 21, 2022

View reviewed changes

KarenPudner reviewed Sep 22, 2022

View reviewed changes

Comment thread 3-extra/3-fibonacci.js

}

return result;

}

KarenPudner Sep 22, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - this is clear concise code and works well.

KarenPudner approved these changes Sep 22, 2022

View reviewed changes

rebwar1 added 7 commits September 22, 2022 21:38

modify 3-extra/3-fibonacci.js

17b8a1a

modify 1-exercises/B-while-loop/exercise.js

094d141

add break to exit the

9eaf4ab

while loop once you have found the first July date

modify 1-exercises/D-do-while/exercise.js

efd0bc7

use do while 1-exercises/D-do-while/exercise

c0d7936

add comment

c8748a9

2-mandatory/4-stocks.jsI explaned what "_, { length } "does here

75e9e86

Uh oh!

Uh oh!

Conversation

rebwar1 commented Sep 20, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KarenPudner Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KarenPudner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KarenPudner Sep 21, 2022 •

edited

Loading