This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM4-Micheale-Andemariam-javascript-core-1-coursework-week3 - #112
Open
micheale2021 wants to merge 4 commits into
Open
WM4-Micheale-Andemariam-javascript-core-1-coursework-week3#112micheale2021 wants to merge 4 commits into
micheale2021 wants to merge 4 commits into
Conversation
Arbeits-Sachen
left a comment
There was a problem hiding this comment.
Great Work, I didnt see any problems.
| // TODO | ||
| let count = 0; | ||
| let result = []; | ||
| while(count < birthdays.length){ |
There was a problem hiding this comment.
I would recommend a FOR loop here, rather than a WHILE loop.
| let result; | ||
| do { | ||
| result = generateRandomNumber(); | ||
| } while (result <= 50); |
There was a problem hiding this comment.
This is just a matter of opinion, but woulnt it be more effiecient just writing:
Suggested change
| } while (result <= 50); | |
| while(result <= 50) | |
| { | |
| result = generateRandomNumber(); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.