CAPE TOWN- CLASS 1 - SINOMBULELO_PUNGULA - JS_CORE_1 - WEEK_7 - #60
CAPE TOWN- CLASS 1 - SINOMBULELO_PUNGULA - JS_CORE_1 - WEEK_7#60sinopungula wants to merge 4 commits into
Conversation
completed all the work and attempted J-not successsful yet
improvements made to folder L-functions
| return Math.random() * 10; | ||
| } | ||
| return Math.random() * 10; | ||
| } //getNumber will have Math.random() return a random number between 0 (incl.) and 1(excl) and then is multiplied by 10 |
There was a problem hiding this comment.
returns random float between 0 and 10
There was a problem hiding this comment.
Hi. Thank you for your comment.
Great catch with the word float, attention to detail makes all the difference. Thanks!
Google says it returns a random float between 0 and 1-not 10, perhaps this is a typo?
| function percentageNumber(numOfPeople, totalNumOfPeople) { | ||
| return numOfPeople * 100 / totalNumOfPeople; | ||
| } | ||
| var numOfStudents = percentageNumber(15, 23); |
There was a problem hiding this comment.
you should use variables instead of hardcoding the values
| var mentor3 = "Mimi"; | ||
| var mentor4 = "Rob"; | ||
| var mentor5 = "Yohannes"; | ||
| var mentor1 = greeting("Daniel"); |
There was a problem hiding this comment.
you didnt have to redeclare the variables
Tried to improve my functions
|
Well done Sino on this week's work, for getting a grip on javascript and Wowzers to your name being 11 characters long! The only feedback I would like to give you is to ask you to commit more and often, maybe after every second exercise, etc. Also to complete the instructions even though you know the function or command, to be mindful to add the full sentences required in the suggested answer on the readme. Getting in a habit of this will help you in your future career as you are working in teams, where expected guidelines are required and also, some programs will require those full detailed sentences. Here is just a few things I picked up and suggestions to work on: G | Add all detail required not just the sum. I | There is a mistake in your final answer for the mentors, can you spot it? the value is incorrect L exercise 2 | great initiative in creating two files, as this question was definitely not clear, in fact it had errors, and you did manage to solve both exercises. but again simply remember to add the % Well done on a whole! You doing well! Keep committing, remember to include all the details and just check that error in I :) |
|
Hi Sino, Well done on your work and code, keep up the good work!!! |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
completed all the work and attempted J-not successsful yet.
Your Details
Homework Details