This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London 10 - Paulina Wywrot - Javascript Week 1 - #505
Open
PaulinaWywrot wants to merge 2 commits into
Open
Conversation
christina-mifsud
approved these changes
Feb 21, 2023
| function addTaxAndFormatCurrency() {} | ||
| return `£${fullPrice.toFixed(2)}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
Very clear and concise code. Well done!
| /* BETTER PRACTICE */ | ||
|
|
||
| let goodCode = | ||
| let result = add(startingValue,10); |
Contributor
There was a problem hiding this comment.
Nice 😄
Having code on different lines sometimes makes it easier to read.
| @@ -1,16 +1,17 @@ | |||
| // There are syntax errors in this code - can you fix it to pass the tests? | |||
|
|
|||
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| return firstWord.concat(" ", secondWord, " ", thirdWord); |
Contributor
There was a problem hiding this comment.
This is good 👍
Can you think of any other ways to do this?
Maybe https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?