This repository was archived by the owner on Jan 14, 2024. It is now read-only.
london-10-shadi-fakhri-javascript-core-1-coursework-week1 - #500
Open
Shadi38 wants to merge 7 commits into
Open
Conversation
ghost
reviewed
Feb 27, 2023
ghost
left a comment
There was a problem hiding this comment.
Good job on completing the coursework! Let me know if you have any further questions on my comments!
|
|
||
| function convertToUSD() {} | ||
| function convertToUSD(price) { | ||
| let total=price * 1.4; |
There was a problem hiding this comment.
I really like how clear you've made this .
|
|
||
| function convertToBRL() {} | ||
| function convertToBRL(price) { | ||
| let total=parseFloat((((price/100)*99)*5.7).toFixed(2)); |
There was a problem hiding this comment.
i think this is doing quite a lot on one line. Adding an extra line with a variable could make this more clear.
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(price) { | ||
| total=calculateSalesTax(price).toFixed(2) |
|
|
||
| This function should expect to be called with any value which was returned by the shakeBall function. | ||
| */ | ||
| function checkAnswer(answer) { |
| return `Hello, my {name}` is "and I am $age years old`; | ||
|
|
||
| function introduceMe(name, age){ | ||
| return `Hello, my name is ${name} and I am ${age} years old`; |
There was a problem hiding this comment.
I like that you have used string interpolation here, nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
finding errors
What do you still not understand?
Any other notes?