Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions extra/1-currency-conversion.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
Write a function that converts a price to USD (exchange rate is 1.4 $ to £)
*/

function convertToUSD() {}
function convertToUSD(amountGBP) {
return amountGBP * 1.4;
}

/*
CURRENCY CONVERSION
Expand All @@ -15,7 +17,11 @@ function convertToUSD() {}
They have also decided that they should add a 1% fee to all foreign transactions, which means you only convert 99% of the £ to BRL.
*/

function convertToBRL() {}
function convertToBRL(amountGBP) {
convertedAmount = amountGBP * 0.99 * 5.7;
convertedAmount = (Math.round(convertedAmount * 100)/100);
return convertedAmount;
}

/* ======= TESTS - DO NOT MODIFY =====
There are some Tests in this file that will help you work out if your code is working.
Expand Down
21 changes: 13 additions & 8 deletions extra/2-piping.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,31 @@
the final result to the variable goodCode
*/

function add() {

function add(value1, value2) {
return value1 + value2;
}

function multiply() {

function multiply(value3, value4) {
return value3 * value4;
}

function format() {

function format(value5) {
return `£${value5}`;
}

const startingValue = 2;

// Why can this code be seen as bad practice? Comment your answer.
let badCode =
let badCode = format(multiply(add(startingValue, 10)));

/* BETTER PRACTICE */

let goodCode =
let valueAddTen = add(startingValue, 10);
let valueMultiplyByTwo = multiply(valueAddTen, 2);
let goodCode = format(valueMultiplyByTwo);




/* ======= TESTS - DO NOT MODIFY =====
There are some Tests in this file that will help you work out if your code is working.
Expand Down
29 changes: 29 additions & 0 deletions extra/3-magic-8-ball.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,26 @@
Very doubtful.
*/


// This should log "The ball has shaken!"
// and return the answer.

const veryPositive = ["It is certain.", "It is decidedly so.", "Without a doubt.", "Yes - definitely.", "You may rely on it."];
const positive = ["As I see it, yes.", "Most likely.", "Outlook good.", "Yes.", "Signs point to yes."];
const negative = ["Reply hazy, try again.", "Ask again later.", "Better not tell you now.", "Cannot predict now.", "Concentrate and ask again."];
const veryNegative = ["Don't count on it.", "My reply is no.", "My sources say no.", "Outlook not so good.", "Very doubtful."];

function shakeBall() {
//Write your code in here
let answers = veryPositive.concat(positive, negative, veryNegative);
let numberOfAnswers = answers.length;
let randomInteger = Math.floor(Math.random() * numberOfAnswers);
let randomAnswer = answers[randomInteger];
console.log("The ball has shaken!");
return randomAnswer;
}


/*
This function should say whether the answer it is given is
- very positive
Expand All @@ -58,10 +72,25 @@ function shakeBall() {

This function should expect to be called with any value which was returned by the shakeBall function.
*/

let answer = shakeBall();
function checkAnswer(answer) {
//Write your code in here
if (veryPositive.includes(answer)) {
return "very positive";
}
if (positive.includes(answer)) {
return "positive";
}
if (negative.includes(answer)) {
return "negative";
}
if (veryNegative.includes(answer)) {
return "very negative";
}
}


/*
==================================
======= TESTS - DO NOT MODIFY =====
Expand Down
11 changes: 6 additions & 5 deletions mandatory/1-syntax-errors.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a, b, c) {
return a + b + c;
}

function introduceMe(name, age)
return `Hello, my {name}` is "and I am $age years old`;
function introduceMe(name, age) {
return `Hello, my name is ${name} and I am ${age} years old`;
}

function getTotal(a, b) {
total = a ++ b;
total = a + b;

return "The total is total";
return `The total is ${total}`;
}

/*
Expand Down
7 changes: 3 additions & 4 deletions mandatory/2-logic-error.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// The syntax for these functions is valid but there are some errors, find them and fix them

function trimWord(word) {
return wordtrim();
return word.trim();
}

function getStringLength(word) {
return "word".length();
return word.length;
}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;
}

/*
Expand Down
5 changes: 5 additions & 0 deletions mandatory/3-function-output.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@ function getRandomNumber() {
return Math.random() * 10;
}

// Picks a random number between 0 (inclusive) and 1 (non-inclusive) and multiplies it by 10.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good explanation of what happens inside the getRandomNumber() function. How would you describe the end result of calling this function?
Also it's a good practice to add a comment explaining function's behaviour either above or inside the function, rather than below it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns a value which is between 0 and (but not including) 10.


// Add comments to explain what this function does. You're meant to use Google!
function combine2Words(word1, word2) {
return word1.concat(word2);
}

// Joins the variable string of word1 to word2 exactly as shown.

function concatenate(firstWord, secondWord, thirdWord) {
return firstWord.concat(" ", secondWord, " ", thirdWord);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a correct implementation. Is there a way to achieve the same end result without using concat method?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return ${firstWord} ${secondWord} ${thirdWord}

// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.
}
Expand Down
9 changes: 7 additions & 2 deletions mandatory/4-tax.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(amount) {
return amount = (amount * 1.2);
}

/*
CURRENCY FORMATTING
Expand All @@ -17,7 +19,10 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/

function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(amount) {
tax = calculateSalesTax(amount);
return `£${tax.toFixed(2)}`;
}

/*
===================================================
Expand Down