This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow 6 - Mandy Cheung - JS1 - Week 1 - #482
Open
m4ndycheung wants to merge 21 commits into
Open
Conversation
Well that was a challenge!
lazar-eva
reviewed
Feb 19, 2023
For the second part of this exercise, I used Number() and toFixed() so that my answers would pass the npm tests. The tests wouldn't accept incorrect decimal places it seems..
PaulinaWywrot
left a comment
There was a problem hiding this comment.
Good job Mandy, I think your code is very organised and neatly written. I also like your notes added to some of the exercises.
msimmdev
reviewed
Feb 27, 2023
msimmdev
left a comment
There was a problem hiding this comment.
Praise: Really good work Mandy, well done on completing the extra questions I found no issues in those answers
Declared total using let so that total can't be accessed outside the getTotal function.
Agree with Michael's feedback so tweaked my solutions.
mandatory: removed ToFixed function - I'll come back to this one. extra: moved let randomAnswer declaration so that it lives inside the shakeBall function for best practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Finding the syntax errors
What did you find hard?
getting my head around functions - understanding inputs
What do you still not understand?
Any other notes?