This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 6 - Christina Mifsud - JS1 - Week 1 - #475
Open
christina-mifsud wants to merge 8 commits into
Open
Conversation
maxbmaapc
reviewed
Feb 16, 2023
maxbmaapc
reviewed
Feb 16, 2023
maxbmaapc
reviewed
Feb 16, 2023
Comment on lines
22
to
25
| function getStringLength() { | ||
| let phrase = "A wild sentence appeared!"; | ||
| return phrase.length; | ||
| } |
There was a problem hiding this comment.
Suggested change
| function getStringLength() { | |
| let phrase = "A wild sentence appeared!"; | |
| return phrase.length; | |
| } | |
| function getStringLength(word) { | |
| return word.length; | |
| } |
Co-authored-by: Maksim Lukianenko <93668989+Mpanasetckiy@users.noreply.github.com>
Updated 1-syntax-errors.js following feedback
Co-authored-by: Maksim Lukianenko <93668989+Mpanasetckiy@users.noreply.github.com>
munozirianni1988
suggested changes
Feb 18, 2023
Co-authored-by: Irianni Munoz <82213740+munozirianni1988@users.noreply.github.com>
munozirianni1988
suggested changes
Feb 18, 2023
Co-authored-by: Irianni Munoz <82213740+munozirianni1988@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details
Notes
What did you find easy?
What did you find hard?
Doing the exercises before the class.
What do you still not understand?
Why I needed to comment out some exercises for the test to work.
Any other notes?