Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

LONDON CLASS 7 - NIGEL PELVIN - JS CORE - WEEK 1 - #47

Closed
nPelvin wants to merge 1 commit into
CodeYourFuture:masterfrom
nPelvin:master
Closed

LONDON CLASS 7 - NIGEL PELVIN - JS CORE - WEEK 1#47
nPelvin wants to merge 1 commit into
CodeYourFuture:masterfrom
nPelvin:master

Conversation

@nPelvin

@nPelvin nPelvin commented Jan 21, 2021

Copy link
Copy Markdown

exercises and mandatory sections complete

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

exercises and mandatory sections complete

@mulindierick mulindierick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this is fantastic. Well done.

@@ -1 +1,2 @@
console.log("Hello world");
console.log("Hello world, I just started learning JavaScript!");
console.log("Potato");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pelvin. Nice job.
just wanted to say, what happened when you removed the quotes from the values insides the logs?
for example, what happens when you console.log(Potato);
I am not sure if it is necessary to present here, but I somehow expected some sort of comment lighting what happens in such a case since it was on the exercise. Same applies to using a number

console.log(message);
var greetingStart="Hello, My name is ";
var firstName="Nigel";
var greeting=greetingStart + firstName;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much of a big deal, but I would suggest you improve a little bit on the indentation of your code. Space before and after the equal sign would make your code look less congested

var mentor3 = "Mimi";
var mentor4 = "Rob";
var mentor5 = "Yohannes";
var greeting = "HELLO ";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how you approached this one. Rember you need two functions. so your greeting is supposed to be a function and not a variable.
see the instruction "Your program should include a function that spells their name in uppercase, and a function that creates a shouty greeting."

let me know if you need help working out the solution.

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label May 13, 2021
@github-actions github-actions Bot closed this May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants