This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London9 - Turing - Ying Xing - JavaScript-Core-1-Coursework-Week1 - #455
Open
LexiisYing wants to merge 6 commits into
Open
London9 - Turing - Ying Xing - JavaScript-Core-1-Coursework-Week1#455LexiisYing wants to merge 6 commits into
LexiisYing wants to merge 6 commits into
Conversation
jonnywyatt
reviewed
Nov 27, 2022
jonnywyatt
left a comment
There was a problem hiding this comment.
Looks good!
To push further, try running the tests in the /mandatory folder
| @@ -1,3 +1,5 @@ | |||
| // Start by creating a variable `greeting` | |||
|
|
|||
| let greeting='Hello world' | |||
There was a problem hiding this comment.
This works fine, but if the value of greeting will only be set once and not changed later, const is better than let
| @@ -1,7 +1,9 @@ | |||
| function triple(number) { | |||
| // complete function here | |||
| return number*number*number | |||
There was a problem hiding this comment.
this will cube the number, which isn't the same as multiplying by 3
| @@ -1,4 +1,9 @@ | |||
| // Declare your function here | |||
| function createLongGreeting(name,age){ | |||
| return `hello my name is ${name} and i'm ${age} years old`; | |||
|
|
||
| //The concat() method does not change the existing strings. | ||
|
|
||
| //The concat() method returns a new string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
Syntax, Logic errors
Function output
Need to practice more on function output