This repository was archived by the owner on Jan 14, 2024. It is now read-only.
LONDON CLASS_9-SAGHAR_HOSSEINMARDI_ JAVASCRIPT-CORE-1-WEEk1 - #448
Open
SagharHosseinmardi wants to merge 4 commits into
Open
LONDON CLASS_9-SAGHAR_HOSSEINMARDI_ JAVASCRIPT-CORE-1-WEEk1#448SagharHosseinmardi wants to merge 4 commits into
SagharHosseinmardi wants to merge 4 commits into
Conversation
jonnywyatt
reviewed
Nov 27, 2022
jonnywyatt
left a comment
There was a problem hiding this comment.
Brilliant! Well done for going after the extra exercises as well.
Great start to Javascript @SagharHosseinmardi , you've got this!
| let greetingStart = "Hello, my name is "; | ||
|
|
||
| let greeting = greetingStart + name.trim(); | ||
| let nameLength = name.length; |
There was a problem hiding this comment.
What if name has whitespace characters round it, will this accurately report the length of the actual name itself?
| // Start by creating a variables `numberOfStudents` and `numberOfMentors` | ||
| let numberOfStudents = 15; | ||
|
|
||
| let numberOfMentors = 8; |
There was a problem hiding this comment.
(this comment relates to all the uses of let in this PR).
If the variable value isn't going to be changed after its initial assignment, which is better, let or const?
| var numberOfStudents = 15; | ||
| var numberOfMentors = 8; | ||
| let total = numberOfStudents + numberOfMentors; | ||
| let studentPercentage = Math.round((numberOfStudents / total) * 100); |
| @@ -1,5 +1,5 @@ | |||
| function triple(number) { | |||
| // complete function here | |||
| return number * 6; | |||
| let addingNumber = add(startingValue, 10); | ||
| let multiplyingNumber = multiply(addingNumber, 2); | ||
| let formattingNumber = format(multiplyingNumber); | ||
| let goodCode = formattingNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?