London9 - Lorena Capraru - Javascript- Week2 - #447
Conversation
ehwus
left a comment
There was a problem hiding this comment.
This is an excellent submission - the tests are passing, and the code is readable and makes sense. I would just:
- Ensure that you're using
var/let/constconsistently in your code (https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/) - Make sure that your variable names are descriptive:
fNamefor instance tells me less thanfirstName. As long as you aren't excessively verbose, it's better to give more detail than leave ambiguity in naming.
Great effort, looking forward to seeing your CS skills continue to come through like this throughout the course!
| @@ -1,2 +1,9 @@ | |||
| var numberOfStudents = 15; | |||
| var numberOfMentors = 8; | |||
| var sum = numberOfMentors + numberOfStudents; | |||
There was a problem hiding this comment.
Hi as a new developer it is better to use let or const instead of using var. The fact about const and let is you can’t re-assign another value to the constant x, however let allows you to declare variables.
| @@ -1,3 +1,4 @@ | |||
| const nameD = " Daniel "; | |||
| let message ="My name is " +nameD.trim() +" and my name is " + nameD.trim().length +" characters long."; | |||
| //print the message | |||
There was a problem hiding this comment.
Hi as a new developer it is better to use let or const instead of using var. The fact about const and let is you can’t re-assign another value to the constant x, however let allows you to declare variables.
nice try this looks great
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
everything
What did you find hard?
nothing
What do you still not understand?
i understood it all.
Any other notes?