JavaScript-Core-1-Coursework-Week1 - #446
Conversation
|
done excercise and mandatory |
|
Great work @laxmikckarki! |
| function trimWord(word) { | ||
| return wordtrim(); | ||
| function trimWord (word) { | ||
| return trimWord(); |
There was a problem hiding this comment.
@laxmikckarki Hi, well done!
In think in line 4 (function 1), it is better to use word.trim(), because you use the trim() method to trim the string. If you look at the tests below the exercises, it can give you a clue.
| const priceWithTax = 1.2 * price; | ||
| return priceWithTax; | ||
| function calculateSalesTax(price) { | ||
| return price + (price / 100 * 20); |
There was a problem hiding this comment.
I have done this exercise same as you but I think its better to use parentheses in a way to make your math more clear
| } | ||
| const greeting = createLongGreeting("Daniel", 30); | ||
|
|
||
| console.log(greeting); |
There was a problem hiding this comment.
well done ,I have just an suggestion in line 3 you use two way: and " ". I think its better use one of them.
| return 'hello ' + mentor3; | ||
| } | ||
| let greeting = greetingUpperCase(); | ||
| console.log(greeting.toUpperCase()) No newline at end of file |
There was a problem hiding this comment.
GREAT. I learn from this one I did in different way(I use twice toUpperCase) I will change mine to yours
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?