Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London Class 7 - Adem Alagoz- JavaScript Core 1 - Week 1 - #44

Closed
adam-alagoz wants to merge 5 commits into
CodeYourFuture:masterfrom
adam-alagoz:master
Closed

London Class 7 - Adem Alagoz- JavaScript Core 1 - Week 1#44
adam-alagoz wants to merge 5 commits into
CodeYourFuture:masterfrom
adam-alagoz:master

Conversation

@adam-alagoz

@adam-alagoz adam-alagoz commented Jan 21, 2021

Copy link
Copy Markdown

Your Details

  • Your Name: Adem ALAGOZ
  • Your City: London
  • Your Slack Name: ademalagoz

Homework Details

  • Module: JavaScript Core-1
  • Week:1

@adam-alagoz adam-alagoz changed the title Half of Exercises London Class 7 - Adem Alagoz- JavaScript Core 1 - Week 1 Jan 21, 2021
@askinekincihf

Copy link
Copy Markdown
console.log(2021)
console.log('2021')

needs semi colon at the end of both code.

@askinekincihf

Copy link
Copy Markdown

const NoWhiteSpace = name.trim();

In JavaScript, you can technically use capitalized variable names, but the convention is to use lowercase words for variable names, and capitalized words for constructors.
https://www.w3schools.com/js/js_conventions.asp

@adam-alagoz adam-alagoz reopened this Jan 22, 2021
@adam-alagoz

Copy link
Copy Markdown
Author

Thanks for your feedback Askin.

@@ -1,4 +1,7 @@
// Declare your function first
function divide(num1,num2){
return num1/num2;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adem, great work, my only small suggestion would be to use consistent indenting across your work (eg your "returns"), so that it reads easier.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help Bisi.I will do it.

Comment thread extra/1-currency-conversion.js Outdated

function convertToUSD() {}
function convertToUSD(price) {
return price*1.4;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adem, well done, you have done really great work. just one thing to draw your attention is the indentation. return should be indented 4 space to right as below.

function convertToUSD(price) {
    return price*1.4;
}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Askin I fixed it but w3schools declares 2 space instead of 4

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label May 13, 2021
@github-actions github-actions Bot closed this May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants