Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London- 9- Lovelace - Howard Sun - JS1-coursework-Week1 - #428

Open
howard-ss wants to merge 4 commits into
CodeYourFuture:masterfrom
howard-ss:master
Open

London- 9- Lovelace - Howard Sun - JS1-coursework-Week1#428
howard-ss wants to merge 4 commits into
CodeYourFuture:masterfrom
howard-ss:master

Conversation

@howard-ss

@howard-ss howard-ss commented Nov 22, 2022

Copy link
Copy Markdown

done 'exercise' and 'mandatory' tasks

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Howard
  • Your City: London , UK
  • Your Slack Name: Howard

Homework Details

  • Module: JS1 - coursework
  • Week: 1

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?


View rendered exercises/G-numbers/README.md

done 'exercise' and 'mandatory' tasks
updated 2 tasks in extra:
1- currency-conversion.js;
2-piping.js
Comment thread exercises/G-numbers/exercise.js Outdated

let totalNum = numberOfStudents + numberOfMentors;

console.log("Number of students: "+ numberOfStudents);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Howard, since you are calculating the total sum of students and mentors in the totalNum variable;
console logging that and concatenate a string before the total should do the trick

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tony,
Thanks for your review !
You are right to do that way.

@@ -1,3 +1,7 @@
// Start by creating a variable `message`

let message = [] ;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this test passed, but I would normally expect message to be a string and not an array.

//let messageLength = messageName.length

//let message = "My name is Daniel and my name is " + messageLength + " characters long";
let message = `My name is ${name} and my name is ${name.length} characters long`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of string interpolation!

Comment thread extra/2-piping.js
let goodmultiply = multiply(2,goodadd);

let goodCode =
let goodCode = format(goodmultiply);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Comment thread extra/3-magic-8-ball.js
//Write your code in here
if ( answer === positive ) {

console.log("The ball has shaken " + answer );

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, only "The ball has shaken!" should be in the console log. The answer should be picked at random from the possible answers.

Comment thread extra/3-magic-8-ball.js
by the shakeBall function.
*/
function checkAnswer(answer) {
//Write your code in here

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should take any of the possible random answers and then return if the answer is very positive, positive, negative or very negative.

@mcarballopacheco mcarballopacheco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Howard!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants