This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London_9 - Andriana Saffo - JavaScript - Week_1 - #425
Open
AndrianaOS wants to merge 28 commits into
Open
Conversation
Only a commented out text added to page as reference
Exercise 2-logic-error of mandatory folder completed and tests passed
Exercise 3-function-output in mandatory folder completed
Exercise 4 in mandatory folder completed and tests passed
Exercise in L-functions-nested has been completed
Currency conversion in the extra folder completed and passed testing
@ piping completed in extra folder and test passed
gladwindos
reviewed
Nov 25, 2022
gladwindos
left a comment
There was a problem hiding this comment.
This looks really good! The only thing I would suggest is to get in the habit of using const instead of let or var when you know the variable you are creating is not going to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Using console.log to find out the output of my functions
What did you find hard?
Nested functions and finding the right math function
What do you still not understand?
How to execute exercise L-functions-nested in the exercise folder