This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 7 - Laura M - JavaScript Core 1 - Week 1 - #42
Closed
Laura-TM wants to merge 5 commits into
Closed
Conversation
Comment on lines
+9
to
+15
| var myGreeting = | ||
| "My name is " + | ||
| name + | ||
| " and my name is " + | ||
| name.length + | ||
| " characters long"; | ||
| return myGreeting; |
There was a problem hiding this comment.
Great Job! As a challenge, you can make use of template literals to tidy up the code and make it easier to read. This link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals and video: https://youtu.be/NgF9-pdTDGs are quite useful - should you need them.
Author
There was a problem hiding this comment.
Thank you! It auto-formatted that way on save :-)
amellie
suggested changes
Jan 25, 2021
amellie
left a comment
There was a problem hiding this comment.
Well done on your work, Laura! Just a few errors in the code. Would you be able to fix them please?
|
Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details