This repository was archived by the owner on Jan 14, 2024. It is now read-only.
MANCHESTER NW5 - ANVAR AZIZI - JavaScript - WEEK_1 - #387
Open
rebwar1 wants to merge 7 commits into
Open
Conversation
mhallaq
reviewed
Aug 26, 2022
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(price) { | ||
| let taxOf = (price * 20) / 100; |
There was a problem hiding this comment.
Consider variable name taxOf : a proper naming way will be more clearer when defnining variables.
|
|
||
| let goodCode = | ||
| let goodCode = format(24); | ||
| let goodCode1 = add(10, 2); |
There was a problem hiding this comment.
Nice work , and consider naming the variables in a clearer way .
KarenPudner
reviewed
Aug 29, 2022
| `Number of students: ${numberOfStudents} | ||
| Number of mentors: ${numberOfMentors} | ||
| Total number of students and mentors: ${total}` | ||
| ); |
KarenPudner
reviewed
Aug 29, 2022
| const mentor4 = "Rob"; | ||
| const mentor5 = "Yohannes"; | ||
| const names = [mentor1, mentor2, mentor3, mentor4, mentor5]; | ||
|
|
There was a problem hiding this comment.
Good - unused code should be deleted.
KarenPudner
reviewed
Aug 29, 2022
| function getRandomNumber() { | ||
| return Math.random() * 10; | ||
| //random returns with 10 will result in a max value of 9.999 | ||
| //random returns with 10 will result in a max value of 9.999 and the lowest value is 0 |
KarenPudner
reviewed
Aug 29, 2022
| let goodCode = format(startingValue); | ||
| let goodCode = format(24); | ||
| let goodCode1 = add(10, 2); | ||
| let goodCode2 = multiply(10, 2); |
There was a problem hiding this comment.
You should be starting with the value of 2, then adding 10, then multiplying by 2, then formatting - the result of each function should be passed to the next function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?