Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Leeds NW5 - Ekrem Teke- JavaScript-Core-1-Week 1 - #374

Open
Ekremteke wants to merge 22 commits into
CodeYourFuture:masterfrom
Ekremteke:master
Open

Leeds NW5 - Ekrem Teke- JavaScript-Core-1-Week 1#374
Ekremteke wants to merge 22 commits into
CodeYourFuture:masterfrom
Ekremteke:master

Conversation

@Ekremteke

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Ekrem Teke
  • Your City: Leeds
  • Your Slack Name: Ekrem Teke

Homework Details

  • Module: JavaScript
  • Week: 1

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@Refik48

Refik48 commented Aug 23, 2022

Copy link
Copy Markdown

Good job, 👏👏👍
Variables are declared with the let and const keywords.
You should never use var.This is an outdated way of writing JavaScript code and it is always better to use let or const. 👍

@AnoshMalik AnoshMalik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests seem to pass, other than the /extra ones.
Should get a green tick after those are done!

Comment thread mandatory/2-logic-error.js
@Ekremteke

Copy link
Copy Markdown
Author

Many thanks @Refik48. I learned it after I completed the coursework I won't use it again:)

@Ekremteke

Copy link
Copy Markdown
Author

If I didn't do anything about extras, it would have gotten the green tick. I solved 1 and 2 but I broke the third one :D

var mentor5 = "Yohannes";

function changeToUppercase(name) {
return (upperCasename = name.toUpperCase());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) it would be clearer if you created a let here and then called it on return.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @luan-murilo-de-oliveira-e-souza , I agree with you.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, I learned some new things from your code.

@Ekremteke

Copy link
Copy Markdown
Author

Thank you @luan-murilo-de-oliveira-e-souza :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants