Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London Class 7 - Murat Demirtas - JavaScript-Core-1-Week 1 - #37

Closed
muratdemirtas2001 wants to merge 4 commits into
CodeYourFuture:masterfrom
muratdemirtas2001:master
Closed

London Class 7 - Murat Demirtas - JavaScript-Core-1-Week 1#37
muratdemirtas2001 wants to merge 4 commits into
CodeYourFuture:masterfrom
muratdemirtas2001:master

Conversation

@muratdemirtas2001

Copy link
Copy Markdown

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

console.log(message);
let message="Hi everyone,nice to meet you, I am "

let name="Murat"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a semi-colon ; at the end of the line of code

// Start by creating a variable `message`

console.log(message);
let message="Hi everyone,nice to meet you, I am "

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a semi-colon ; at the end of the line of code


function convertToBRL() {}
function convertToBRL(price) {
let newPrice = (price * 99) / 100;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: You could do price * 0.9;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kara, you have spotted every detail.I appreciate your support.

@kmh256 kmh256 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Murat! I have added a couple of comments :)

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label May 13, 2021
@github-actions github-actions Bot closed this May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants