This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM4 - Michelle Janay - JavaScript - Week 1 - #319
Closed
michellejanay wants to merge 14 commits into
Closed
Conversation
WM4 - Michelle Janay - JavaScript - Week 1
bug commented out in console, all tests passing
| const multiplied = multiply(added, 2); | ||
| let goodCode = format(multiplied); | ||
| console.log(goodCode); | ||
| //This code is better, because you can see step by step what is happening, and you are also storing each value into a variable, which you could use later. |
There was a problem hiding this comment.
Hi,
I had a look at your code and I really like your example with the good and bad code.
Its really interresting how people made the good/bad code task differntly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
I found it easy to complete the exercises as they were very similar to what we did in class
What did you find hard?
I found it challenging to understand exactly the BRL problem in the extras folder. I got very stuck on the 99% part, but Chizim helped me by giving a real world example.
What do you still not understand?
Why the test is failing one part of the magic 8 ball challenge.
Any other notes?
Yes, in the magic 8 ball challenge, within the test result, it is not showing the 'very negative' sequence even though it is written in the test. That's the part the test is failing. I'm unsure why.
EDIT: I had asked in the slack channel about why the test was failing, and James confirmed, it looks like there is a bug in the test.