This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WM_4-Joanna_Jurczuk-JavaScript-1 - #312
Closed
joannajurczuk94 wants to merge 3 commits into
Closed
Conversation
Nagehan1
reviewed
Jul 31, 2022
Nagehan1
left a comment
There was a problem hiding this comment.
hi Joanna,
In introduceMe function, if you define name and age variable you can use this function with different variable
nholdsworth94
left a comment
Contributor
There was a problem hiding this comment.
Hey Joanna,
This homework is syntactically fantastic, very well done!
Just be careful about your spaces - look at the tests that haven't passed to see what I mean
Try updating your code to get the tests to pass if you get time :)
Comment on lines
+6
to
+7
| var message = "string"; | ||
| var messageType = typeof message; |
Contributor
There was a problem hiding this comment.
be careful declaring variables with the same name several times as it will cause an error
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(productPrice) { | ||
| let productTax = productPrice * 0.2; |
Contributor
There was a problem hiding this comment.
you could have used the function above, e.g.
let productTax = calculateSalesTax(productPrice);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?