This repository was archived by the owner on Jan 14, 2024. It is now read-only.
ZA2-Harerimana-Dieudonne-JavaScript-Core-1-Coursework-Week1 - #307
Closed
diegoharera wants to merge 4 commits into
Closed
ZA2-Harerimana-Dieudonne-JavaScript-Core-1-Coursework-Week1#307diegoharera wants to merge 4 commits into
diegoharera wants to merge 4 commits into
Conversation
BereniceOgundele
left a comment
There was a problem hiding this comment.
Hi Harerimana, it looks like you put in a lot of time and effort to complete these exercises. Well done for hanging in there and completing it. All the best going forward...your code looks good.
lexyking
suggested changes
Aug 13, 2022
lexyking
left a comment
There was a problem hiding this comment.
Left few comments but overall great jobs.
| function addTaxAndFormatCurrency(number) { | ||
| return "£" + calculateSalesTax(number).toFixed(2); | ||
| } | ||
| /* |
There was a problem hiding this comment.
Great job on these functions, Can you please have a look at the other function ??
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| return firstWord.concat(" ", secondWord, " ", thirdWord); | ||
| } |
|
|
||
| function getStringLength(word) { | ||
| return "word".length(); | ||
| return word.length(); |
| return "Hello, my name is " + name "and I am " age + "years old"; | ||
|
|
||
| function introduceMe(name, age) { | ||
| return "Hello, my name is " + name + " and I am " + age + " years old"; |
There was a problem hiding this comment.
Well done on this one, I like your attention to detail on those empty spaces.
| console.log(greet(mentor2)); | ||
| console.log(greet(mentor3)); | ||
| console.log(greet(mentor4)); | ||
| console.log(greet(mentor5)); |
|
|
||
| let name = "Diego"; | ||
| let amount = name.length; | ||
| let message = "hello,my name is " + name + " and my name is " + amount + " characters long"; |
|
|
||
| console.log(message); | ||
| let greeting = greetingStart + name; | ||
| console.log(greeting); |
|
|
||
| let message = "my name is Harera"; | ||
| console.log(message); | ||
| console.log(typeof message); No newline at end of file |
| let greeting = "hello Africa"; | ||
| console.log(greeting); | ||
| console.log(greeting); | ||
| console.log(greeting); |
| //console.log("save the world"); | ||
| // console.log("create the world","happy","code your"); | ||
| // console.log(save the world); | ||
| console.log(39); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?