This repository was archived by the owner on Jan 14, 2024. It is now read-only.
ZA2-Kwanda Silekwa-JavaScript-Core-1-Coursework-Week1 - #299
Closed
kwanda9700 wants to merge 9 commits into
Closed
Conversation
Riyaazct
reviewed
Jul 2, 2022
Riyaazct
left a comment
There was a problem hiding this comment.
Hi Kwanda. you finished the Extra exercises as well, Amazing bro. well done.
Author
|
Thank you Riyaaz |
|
Hello Kwanda, I like the way you follow the steps to make your code more understandable. Well done. |
dschouw-CYF
reviewed
Jul 23, 2022
| let greeting = "Hello World"; | ||
|
|
||
| console.log(greeting); | ||
| for (i = 1; i < 4; i++) { |
There was a problem hiding this comment.
Great use of a for loop to perform a repetitive task 👍
| @@ -1,5 +1,29 @@ | |||
| function shoutyGreeting(str) { | |||
There was a problem hiding this comment.
The exercise requires two functions, one that spells their names in uppercase, and one that create a shouty greeting.
While you code works perfectly, maybe consider
Suggested change
| function shoutyGreeting(str) { | |
| function shoutyGreeting(str) { // logs the output ( shout greeting ) | |
| ..... | |
| function upperCaseName(str) { // uppercases the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?