ZA_2-Marvin_Marshall-JS-Core-1-WK1 - #295
Conversation
I have passed all test in the JS files.
|
Keep pushing! |
chezlinbenson
left a comment
There was a problem hiding this comment.
These exercises were good challenges to understand the basic Javascript language. declaring functions, variables, parameters, arguments and naming conventions, were the goals for week1, and you have shown great skills in the javascript basic language. Well Done! Continue following the basic structures and concepts moving forward.
| var total = numberOfStudents + numberOfMentors; | ||
| /*calculation for students*/ | ||
|
|
||
| var text1 = "Percentage of Students "; |
There was a problem hiding this comment.
Great understanding of basic javascript syntax and naming conventions. No need to understand all the words, as long as you understand the concepts.
| @@ -1,4 +1,7 @@ | |||
| // Declare your function here | |||
| function createLongGreeting(name, age){ | |||
There was a problem hiding this comment.
Understanding string concaternation takes basic exercises like these. You did well in this exercise analysing your code and code stucture.
| var mentor5 = "Yohannes"; | ||
|
|
||
|
|
||
| function shoutyGreeting(name){ |
There was a problem hiding this comment.
This exercise had many trainees get to use more of their brains. There are many solutions to any code. Your basic functions show great understanding on Declaring Functions and returning them. Well done!
| return Math.random() * 10; | ||
| } | ||
|
|
||
| //The above function grabs a random number by using the Math.random() method and multiplies that random number by 10. |
There was a problem hiding this comment.
Very good comments. They are clear and uses the Javascript proper commenting.
| */ | ||
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(price){ |
There was a problem hiding this comment.
Very clean code, well done! There are various options to the functions you are coding to make it shorter. Making use of the correct methods in your code, are best practise, Well done there!
| total = a ++ b; | ||
|
|
||
| return "The total is total"; | ||
| return "The total is " + (a + b); |
There was a problem hiding this comment.
Good call using the brackets here + (a + b) 👌
I have passed all test in the JS files.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
View rendered exercises/B-hello-world/README.md