ZA2_Nishka-Kisten-JavaScript-Core-1-Coursework-Week1 - #293
Conversation
|
This is very well done and it is also refreshing to see a different view on how you've written your code. |
chezlinbenson
left a comment
There was a problem hiding this comment.
Amazing understanding of the basic Javascript syntax and naming conventions. No need to know all words, as long as you understand the concepts.
| @@ -1 +1,4 @@ | |||
| console.log("Hello world"); | |||
| console.log("Nishka Kisten"); | |||
There was a problem hiding this comment.
Amazing use of the javascript syntax.
| @@ -1,3 +1,5 @@ | |||
| // Start by creating a variable `message` | |||
|
|
|||
| var message = "This is a string"; | |||
There was a problem hiding this comment.
Very neat code here. Keep that up!
| var numberOfMentors = 8; | ||
| var studentsAndMentors = numberOfStudents + numberOfMentors; | ||
|
|
||
| var messageStudents = "Number of students: " + numberOfStudents; |
There was a problem hiding this comment.
This is great javascript basics. You understanding the basic concept to declaring variables and assigning arguments to them. Well done!
| */ | ||
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(num) { |
There was a problem hiding this comment.
This is amazing code. Making use of good naming conventions and ignoring unclear function names.
dschouw-CYF
left a comment
There was a problem hiding this comment.
Thank you and well done for submitting your coursework Nishka.
Try and commit more often ( there is only one commit in the pull request ), and if you have time, try and complete the extra challenges.
|
|
||
| // console.log(result2); | ||
|
|
||
| function shoutyGreeting(name, string){ |
There was a problem hiding this comment.
Well done Nishka 💯
Maybe consider moving shoutyMessage variable into the shoutyGreeting function , since its only used in the function
| function shoutyGreeting(name, string){ | |
| function shoutyGreeting(name, string){ | |
| let shoutyMessage = "hello" | |
| ... rest of function | |
| // Add comments to explain what this function does. You're meant to use Google! | ||
| function getRandomNumber() { | ||
| return Math.random() * 10; | ||
| return Math.random() * 10; // it returns a random number that can be anywhere between 0 and 1. The 0 is included and 1 is excluded. |
There was a problem hiding this comment.
Comment is clear, well done.
You've described the function Math.random well, but note the multiply by 10. What do you think the function returns with the multiply by 10?
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
View rendered exercises/B-hello-world/README.md
View rendered exercises/F-strings-methods/README.md
View rendered exercises/G-numbers/README.md