Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

ZA2 - Temwa Nyirenda - Week #6 Coursework (JavaScript Core I - Lesson 1) - #291

Closed
TemwaNyirenda wants to merge 3 commits into
CodeYourFuture:masterfrom
TemwaNyirenda:master
Closed

ZA2 - Temwa Nyirenda - Week #6 Coursework (JavaScript Core I - Lesson 1)#291
TemwaNyirenda wants to merge 3 commits into
CodeYourFuture:masterfrom
TemwaNyirenda:master

Conversation

@TemwaNyirenda

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Temwa Nyirenda
  • Your City: South Africa
  • Your Slack Name: Temwa Nyirenda

Homework Details

  • Module: JavaScript Core I - Lesson 1
  • Week: 6

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@mfukechristian mfukechristian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice , very very nice

@Nishka-Kisten Nishka-Kisten left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!! Your naming of variables are very clear too. It was lovely reading through your code. Well done!

@chandredewet chandredewet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Temwa,

Wow, I see your maths have helped you in sales tax with * 1.2.

greeting = "Finally you're here! Come on in, ";

function createAShoutyMessageWithName(message, name) {
return (createAShoutyMessage(message) + shoutName(name));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Temwa,

Great work, just a suggestion, u could have used the same function, e.g shoutName perhaps just named differently to capitalise the shouty message.

@chandredewet chandredewet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Temwa,

Apologies for the limited comments, but well done on interesting greetings throughout and doing most of the extra exercises, wow, your JS is going to be strong as a result.

I have only made one change - the use of the function in shouty greeting. and would like to commend u on knowing how to work out mathematically the price including 20%

@diegoharera diegoharera left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TemwaNyirenda, These exercises were good to understand the basic Javascript language. declaring functions, variables, parameters, arguments, and naming conventions, were the goals for week1, and you have shown great skills in the basic javascript language. Well Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants