South Africa - Ntshembo Hlongwane - #29
Conversation
JarrodBen
left a comment
There was a problem hiding this comment.
I like the way you step away from a changeable var to a const in some instances, good way of looking at things and solving them, I would suggest trying to give the answers that some exercises are looking for and experiment with the exercises in your own time just to be safe, and you do understand what is expected of you with this exercise, well done.
@JarrodBen Thanks for the review I will look into what you said but you loosing me a bit here (The sentence above) please open it up a bit for me thanks |
|
I think the answers that they are looking for is in the readme files of each of the exercises, but it's good that you also experimented with the code as well, that's all. |
|
I did give answers from the Readme.md file which exercise did I give an answer not stated in the Readme.md file would be helpful to know |
| const util = require("util"); | ||
|
|
||
| function test(test_name, actual, expected) { | ||
| let status; |
There was a problem hiding this comment.
You edited the test runs??? You are extra-ordinary.
There was a problem hiding this comment.
No I never thouched those Unit Tests written the
| // Add comments to explain what this function does. You're meant to use Google! | ||
|
|
||
| /** | ||
| * @description Function concatenates 2 values together |
There was a problem hiding this comment.
This is excellent. You gonna create libraries that we will re-use very soon. Keep it up
There was a problem hiding this comment.
Thanks a lot bro appreciate it
|
Great work bro! everything is awesome on the technical side, however check your pull request comment you did not fill in the week and module fields. |
@bradleymubenga777 Thanks man slipped my mind I will fill in those things now |
| function checkAnswer(answer) { | ||
| //Write your code in here | ||
|
|
||
| const possibleAnswers = [ |
There was a problem hiding this comment.
why do we have an array with 1 object, as opposed to just having an object?
| ]; | ||
|
|
||
| let status = ''; | ||
| possibleAnswers.forEach((array) => { |
There was a problem hiding this comment.
how many times will this forEach iterate?
| } | ||
|
|
||
| if (array.veryNegative.includes(answer)) { | ||
| status = 'very negative'; |
There was a problem hiding this comment.
if the answer is found in "first" condition, it will continue to run down to this line, how can we stop this?
|
|
||
| function getTotal(a, b) { | ||
| total = a ++ b; | ||
| const total = a + b; |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
Your Details
Homework Details