This repository was archived by the owner on Jan 14, 2024. It is now read-only.
ZA2 | JavaScript-core1-week1 by Advocate - #286
Closed
AdvocateM wants to merge 8 commits into
Closed
Conversation
Xolani-M
reviewed
Jun 29, 2022
| return number - 6; | ||
| } | ||
|
|
||
| var result = halve(12); |
There was a problem hiding this comment.
Hey Advocate,
Your code only works in a condition where the argument is equal to 12, when i put halve(24) or any other number except 12 it won't meet the requirement. Consider using a different operator instead of the (minus) operator for your code to work in different conditions. Overall you on the right track, well done.
Thanks
AnthonyMogotlane
suggested changes
Jun 30, 2022
AnthonyMogotlane
left a comment
There was a problem hiding this comment.
Keep up the good work Advocate.
M3ntalist
reviewed
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title for your pull request should be made in this format
Cape-Town-2- Advocate Maroga - JavaScript-Core-1-Week1
Your Details
— Your Name: Advocate
— Your City: Cape Town
— Your Slack Name: mrmaroga
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?