This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class_8-Busra Erdogan-JS-Week_1 - #253
Closed
BusraElmasErdogan wants to merge 3 commits into
Closed
Conversation
mandatory completed (1 to 4)
Hatice06
reviewed
Dec 17, 2021
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(productPrice) { | ||
| const total = productPrice + productPrice * 0.2 ; | ||
| return `£${total.toFixed(2)}`; |
There was a problem hiding this comment.
Hi Busra, good job with using string interpolation. Well done!!
kolomiets
reviewed
Dec 19, 2021
| ``` | ||
|
|
||
| You can use mathematical operators to caclulate numbers: | ||
| You can use mathematical operators to calculate numbers: |
There was a problem hiding this comment.
👍 :) Thanks for fixing the spelling errors! It happens all the time in real projects. It's very useful to have a spellchecker configured in your IDE
| let numberOfMentors = 8 * 2; | ||
| console.log(mentors + numberOfMentors); | ||
| let totalText = 'Total number of students and mentors: '; | ||
| let total = numberOfMentors + numberOfStudents; |
There was a problem hiding this comment.
Very good choice of variable names, the code is easy to follow.
| return grt + name; | ||
| }; | ||
|
|
||
| let write = greetingMentors(greeting, mentor1); |
There was a problem hiding this comment.
All these 5 greetings below are essentially the same code, only the mentor name is different. Could you create another function to reduce duplication of the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
Functions
What do you still not understand?
I half-understood the functions.
Any other notes?
View rendered exercises/G-numbers/README.md