Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

London Class 8 - Amarachi Okereke - JavaScript-Core-1-Coursework-Week 1 - #245

Closed
AmarachiOkereke wants to merge 8 commits into
CodeYourFuture:masterfrom
AmarachiOkereke:master
Closed

London Class 8 - Amarachi Okereke - JavaScript-Core-1-Coursework-Week 1#245
AmarachiOkereke wants to merge 8 commits into
CodeYourFuture:masterfrom
AmarachiOkereke:master

Conversation

@AmarachiOkereke

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Amarachi Okereke
  • Your City: London
  • Your Slack Name: Amarachi Okereke

Homework Details

  • Module: JavaScript-Core-1-Coursework
  • Week: 1

Notes

  • What did you find easy?
    Writing functions that add, multiply or that takes a string as an input.

  • What did you find hard?
    Manipulating functions like calculating percentages, tax etc. It's a bit confusing

  • What do you still not understand?
    Some questions relating to functions are still a challenge

  • Any other notes?
    I will like to request a follow up teaching on functions please if possible to help me have a better understanding of function.

Still working on the mandatory file.
Completed
Still working on the files in this folder

@DelroyGayle DelroyGayle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Amarachi,
Disregard what I said about the placement of your code.
As I have read: There are no “you must” rules
Nothing is set in stone here. These are style preferences, not religious dogmas.

Comment thread mandatory/1-syntax-errors.js Outdated

}

var result = getTotal(14, 14);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'var' is now considered outdated. Please use 'let' instead

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have corrected it.

Still working on this folder
Made some corrections.
@AmarachiOkereke

Copy link
Copy Markdown
Author

Thank you Delroy for your review. Can you please indicate where functions are not correctly written in my code, I have checked my code and it seems to be in the correct order. Thank you

Dear Amarachi, I suggest that all your functions should be placed at the top of the program then followed by the code. That is, the definitions of function add(a, b) {} ... function multiply(a, b) ... function format(number) etc should be at the top; then followed by let's, console.log's etc. So definitions of functions first, followed by the code that uses them. That generally, is the structured approach to writing programs.

New changes in this folder
Still working on this folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants