London Class_8 - Deago Browne - JS - Week_1 by DeagoBrowne · Pull Request #244 · CodeYourFuture/JavaScript-Core-1-Coursework-Week1

DeagoBrowne · 2021-12-15T19:42:17Z

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

Your Name: Deago Browne
Your City: London
Your Slack Name: Deago Browne - Trainee

Homework Details

Module: JS1

Notes

What did you find easy? Most of the early exercises, and most of the npm Tests
What did you find hard? Percentages - though I managed to get it done, and I also found some formulas to use in the future
What do you still not understand? Couldn't add the "£" to the Tax function - gave up, as it was time-consuming, and I have other assignments to complete
Any other notes?

View rendered exercises/B-hello-world/README.md

RitaGlushkova

Hi Deago, as part of our assignment I decided to review your code. I hope you don't mind. Great work! I like how you assign all functions' calls to variables. In my view, it is a very good practice. An overall note would be about using let or const instead of var.
I think if we developed this practice from the beginning we are less likely to cause bugs in the future. Var allows people to completely overwrite it, not just assign a new value. That's why when working in a team, it will be less risky to use let or const.

RitaGlushkova · 2021-12-17T00:01:00Z

+
+
+function addTaxAndFormatCurrency(x) {
+  return (x + 0.20*x).toFixed(2);


Hi Deago, well done for fixing it. If you want to add a pound sign, think of it as a "string" that you add with + in your return formula.

It can be rewritten like this:

return (1.2 * x).toFixed(2);

RitaGlushkova · 2021-12-17T00:06:48Z

 // Add comments to explain what this function does. You're meant to use Google!
 function getRandomNumber() {
  return Math.random() * 10;
+  // returns a random number between 1 <1, then multiplies that number by 10


Hi Deago, I think there is a typo. Did you mean from 0 to < 1?

RitaGlushkova · 2021-12-17T00:14:11Z

-function getStringLength(word) {
-  return "word".length();
+var sentence = "A wild sentence appeared!";
+var word = "Turtles";


Your variable is declared correctly. I would recommend using let instead. Because if you work with someone else on a very big piece of code, another person might come up with the same variable name word and without knowing rewrite yours. It will then can then cause a problem.

RitaGlushkova · 2021-12-17T00:19:39Z

 function multiply(a, b, c) {
-  a * b * c;
-  return;
+  return  a * b * c;;


I think there is an extra ;

mahsa2

Well done on finishing the assignment 💯 👏

mahsa2 · 2021-12-20T19:38:47Z

@@ -1,3 +1,5 @@
 // Start by creating a variable `message`
+var myName = "Deago";
+var nameLength =`My name is Deago, and my name is ${myName.length} characters long`;


Great use of concatinating string here ⭐

Also you can use this to add your name.

var -> const (or let if the value changes)

const nameLength = `My name is ${myName}, and my name is ${myName.length} characters long`;

mahsa2 · 2021-12-20T19:47:14Z

-
+const name = " Deago  ";
+nameLength = name.length
+var message = `My name is ${name.trim()} and my name is ${name.trim().length} characters long`


You could store the name.trim() in the variable:

let name = " Deago "; name = name.trim(); nameLength = name.length;

You need to use semicolom

mahsa2 · 2021-12-20T19:50:50Z

@@ -1,7 +1,7 @@
 function halve(number) {
-  // complete the function here
+  return number / 2


mahsa2 · 2021-12-20T19:51:20Z

 }

-var result = halve(12);
+var result = halve(512);


console.log(halve(512));

mahsa2 · 2021-12-20T19:51:58Z

@@ -1,5 +1,5 @@
 function triple(number) {
-  // complete function here
+  return number * 3


mahsa2 · 2021-12-20T19:54:25Z

@@ -1,4 +1,8 @@
 // Write your function here
+function createGreeting (a) {
+    return "Hello, my name is " + a


It's better to use this format in general.

return `Hello, my name is ${a}`;

mahsa2 · 2021-12-20T19:59:36Z

+    return b.toUpperCase();
+}
+
+function message (b) {


message (b) -> message(b) (no space)

mahsa2 · 2021-12-20T20:02:38Z


-function introduceMe(name, age)
-  return "Hello, my name is " + name "and I am " age + "years old";
+var name = "Sonjide";


This is not needed in the test.

mahsa2 · 2021-12-20T20:05:10Z

 }

 function concatenate(firstWord, secondWord, thirdWord) {
+


No new line needed at the begining of the function.

mahsa2 · 2021-12-20T20:07:53Z

+
+
+function addTaxAndFormatCurrency(x) {
+  return (x + 0.20*x).toFixed(2);


It can be rewritten like this:

return (1.2 * x).toFixed(2);

DeagoBrowne added 3 commits December 12, 2021 19:50

Completed exercises

60b347a

Finished all main exercises

a79c728

Can't get the pound sign to work - done.

a83ddd6

RitaGlushkova reviewed Dec 17, 2021

View reviewed changes

mahsa2 reviewed Dec 20, 2021

View reviewed changes

mahsa2 added LDN8 reviewed labels Dec 20, 2021

made an attempt at the extras folder

5537145

SallyMcGrath closed this Mar 4, 2023



		function addTaxAndFormatCurrency(x) {
		return (x + 0.20*x).toFixed(2);

Uh oh!

Uh oh!

Conversation

DeagoBrowne commented Dec 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your Details

Homework Details

Notes

Uh oh!

RitaGlushkova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mahsa2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DeagoBrowne commented Dec 15, 2021 •

edited

Loading