This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 8 - Davood Khoshnood - JavaScript - Core 1 - Week 1 - #237
Closed
DavoodKhoshnood wants to merge 6 commits into
Closed
London Class 8 - Davood Khoshnood - JavaScript - Core 1 - Week 1#237DavoodKhoshnood wants to merge 6 commits into
DavoodKhoshnood wants to merge 6 commits into
Conversation
teniolao
suggested changes
Dec 17, 2021
| } | ||
|
|
||
|
|
||
| var mentor1 = "Daniel"; |
There was a problem hiding this comment.
Hi Davood, i would recommend you use let rather than var. It is an outdated way to name variables and let is better.
Author
There was a problem hiding this comment.
Hi Teniolao, I've changed and committed it again. thanks.
change var to let
DiegoJunior0
reviewed
Jan 2, 2022
| }); | ||
| test('getTotal returns a string describing the total', () => { | ||
| expect(getTotal(23, 5)).toEqual('The total is 28') | ||
| }) |
There was a problem hiding this comment.
I assume you didn't mean to change all these tests, I assume from a change all? Be careful when doing this when tests are in the same file (though in the real world that wouldn't be case!)
|
Excellent work Davood! |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
View rendered exercises/B-hello-world/README.md