This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London class 8 - Craig D'Silva - JavaScript Core 1 - week 1 - #235
Closed
craig-dsilva wants to merge 5 commits into
Closed
London class 8 - Craig D'Silva - JavaScript Core 1 - week 1#235craig-dsilva wants to merge 5 commits into
craig-dsilva wants to merge 5 commits into
Conversation
DomVinyard
reviewed
Dec 17, 2021
|
|
||
| const startingValue = 2; | ||
|
|
||
| // Why can this code be seen as bad practice? Comment your answer. |
There was a problem hiding this comment.
Still need to answer this question (with a comment)
Author
There was a problem hiding this comment.
Sorry, I forgot about this.
DomVinyard
reviewed
Dec 17, 2021
|
|
||
| let sum = add(startingValue, 10); | ||
| let product = multiply(sum, 2); | ||
| let formatted = `£${product}`; |
There was a problem hiding this comment.
is this going to always produce the correct two decimal places?
Author
There was a problem hiding this comment.
No, but now I have added Math.round() to product because the tests provided fails with a decimal value.
DomVinyard
reviewed
Dec 17, 2021
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(amount) { | ||
| return (amount * 20) / 100 + amount; |
There was a problem hiding this comment.
this doesn't seem quite right. This function should just calculate the sales tax (not add the sales tax).
return amount * 0.2
DomVinyard
reviewed
Dec 17, 2021
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(amount) { | ||
| return `£${calculateSalesTax(amount).toFixed(2)}`; |
There was a problem hiding this comment.
this is where we add the sales tax
function addTaxAndFormatCurrency(amount) {
const tax = calculateSalesTax(amount)
const total = amount + tax
// etc
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The exercises were easy to understand
What did you find hard?
The magic 8 ball
What do you still not understand?
I didn't understand what to do for magic 8 ball
Any other notes?