This repository was archived by the owner on Jan 14, 2024. It is now read-only.
WEST_MIDLANDS CLASS_3 - TENZIN_SAMDUP - JAVASCRIPT_CORE1 - WEEK_1 - #190
Closed
tenzyns wants to merge 19 commits into
Closed
WEST_MIDLANDS CLASS_3 - TENZIN_SAMDUP - JAVASCRIPT_CORE1 - WEEK_1#190tenzyns wants to merge 19 commits into
tenzyns wants to merge 19 commits into
Conversation
Corrected syntax errors
Logic error fixed
Added comments and corrected the 3rd function
Sales tax function created
Exercise B completed
completed exercise C
Added variable and typeof command
Greetings concatenation added.
My name's character length is printed.
used string trim function and character length.
G-numbers exercise completed
Floats exercise completed
2 exercises in J-function folder completed. Added function that halves a number and another function that triples a number.
Completed exercises on function parameters.
Shouty greeting completed
currency conversion test passed
Completed nested functions
Roman-Hal
reviewed
Aug 14, 2021
Roman-Hal
left a comment
There was a problem hiding this comment.
Great job. I like the coding you have done.
|
|
||
| let message = "Save the planet earth!" | ||
| console.log(message); | ||
| let messageType = typeof message; |
There was a problem hiding this comment.
Looks great. typeof message can be added directly into the console.log without creating additional variable. I like your work.
Magic ball solved.
Updated if statement for function checkAnswer().
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Writing the simple functions
What did you find hard?
I don't understand how to write the function for 8ball; It was hard to find the function for rounding numbers to 2 decimal place as the to.Fixed(2) output number to string characters.
What do you still not understand?
I still don't know how to write the function for magic 8 ball, especially the 1st function about, asking a question, shaking the ball and getting an answer. I wonder how to write the function that gives one of the 20 answers.
Any other notes?