This repository was archived by the owner on Jan 14, 2024. It is now read-only.
West Midlands 2 - Jasvir Kaur - JavaScript Core 1 - Week 1 - #18
Closed
JK1320 wants to merge 2 commits into
Closed
Conversation
| // Start by creating a variable `greeting` | ||
|
|
||
| var greeting = "Hello World"; | ||
| console.log(greeting); |
There was a problem hiding this comment.
This is correct but was meant to be outputted 3 times
| @@ -1,7 +1,7 @@ | |||
| function halve(number) { | |||
| // complete the function here | |||
| return number - 6; | |||
There was a problem hiding this comment.
This won't halve the number. It will subtract it by 6. You'd need instead this:
return number / 2;
| var mentor3 = "Mimi"; | ||
| var mentor4 = "Rob"; | ||
| var mentor5 = "Yohannes"; | ||
| var mentor5 = "Yohannes" |
There was a problem hiding this comment.
Be careful of doing stuff like this. You'e took the semi colon away by accident.
| var addTax = `£${calculateSalesTax(price).toFixed(2)}`; | ||
| return addTax; | ||
| } | ||
|
|
There was a problem hiding this comment.
All tests for all 4 exercises passed 🎉
|
Your coursework submission has been closed because nobody has interacted with it in 30 days. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details