This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 5 - Grant Frater - JavaScript Week 1 - #158
Closed
grantjfrater wants to merge 2 commits into
Closed
Conversation
ahmedjalalsd
reviewed
Jul 2, 2021
| @@ -1,5 +1,6 @@ | |||
| function halve(number) { | |||
| // complete the function here | |||
| return result = number / 2; | |||
There was a problem hiding this comment.
Good job, you can do the following to save some time
return number / 2;
| } | ||
|
|
||
| // Call the function and assign to a variable `sum` | ||
| var result = sum(13, 124); |
There was a problem hiding this comment.
var is acceptable, but I remember in the class, the teacher said is better to use let
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
Spent half an hour trying to figure out why last exercise wasnt working. Turned out I put greetin3 twice.
What do you still not understand?
Any other notes?