This repository was archived by the owner on Jan 14, 2024. It is now read-only.
First attempt. - #150
Closed
Fareedh-12 wants to merge 1 commit into
Closed
Conversation
Failed to do the third exercise in extra. That is margic-8-ball.js
NadaKartouch
reviewed
Jul 1, 2021
| @@ -1,16 +1,18 @@ | |||
| // There are syntax errors in this code - can you fix it to pass the tests? | |||
NadaKartouch
reviewed
Jul 1, 2021
| @@ -1,16 +1,19 @@ | |||
| // The syntax for this function is valid but it has an error, find it and fix it. | |||
NadaKartouch
reviewed
Jul 1, 2021
| @@ -1,16 +1,23 @@ | |||
| // Add comments to explain what this function does. You're meant to use Google! | |||
| function getRandomNumber() { | |||
| // This gets a random number between 0 and 1(excluded) and multiplies it by 10 | |||
There was a problem hiding this comment.
💯 totally correct .. in other words returns a number between 0 and 9.99999
NadaKartouch
reviewed
Jul 1, 2021
|
|
||
| // Add comments to explain what this function does. You're meant to use Google! | ||
| function combine2Words(word1, word2) { | ||
| //this function joins two words that have been entered as parameters |
NadaKartouch
reviewed
Jul 1, 2021
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| //we could either return them with spaces between them like this ; |
NadaKartouch
reviewed
Jul 1, 2021
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(price) { | ||
| return price + ((20/100)*price); |
There was a problem hiding this comment.
I think this function should return only the tax .. without the price.
NadaKartouch
reviewed
Jul 1, 2021
| */ | ||
|
|
||
| function convertToUSD() {} | ||
| function convertToUSD(initialPrice) { |
NadaKartouch
reviewed
Jul 1, 2021
|
|
||
| function convertToBRL() {} | ||
| function convertToBRL(toBrazilian) { | ||
| return Math.round(toBrazilian*5.7 - (toBrazilian*5.7)*(1/100)) + " BRL"; |
There was a problem hiding this comment.
Totally correct .. could also be Math.round(1005.70.99)
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed to do the third exercise in extra. That is margic-8-ball.js
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy? Attempting all the exercise was easy.
What did you find hard?Understanding the instructions.
What do you still not understand? How to use the tests given and also the three margin ball exercise.
Any other notes?