This repository was archived by the owner on Jan 14, 2024. It is now read-only.
NORTHWEST_4 - Mohammed_Alabdulhamid - JAVA-SCRIPT - WEEK_1 - #142
Closed
Mohammedal-abdulhamid wants to merge 6 commits into
Closed
NORTHWEST_4 - Mohammed_Alabdulhamid - JAVA-SCRIPT - WEEK_1#142Mohammedal-abdulhamid wants to merge 6 commits into
Mohammedal-abdulhamid wants to merge 6 commits into
Conversation
nax2uk
reviewed
Jul 10, 2021
There was a problem hiding this comment.
Please see my feedback below:
I am just wondering if you checked your code by typing and running npm test in your terminal because there are a lot of tests that failed because of syntax errors.
Also, you missed out the last function:
function addTaxAndFormatCurrency(price) {
const priceWithTax = calculateSalesTax(price);
const formattedPrice = '£' + priceWithTax.toFixed(2);
return formattedPrice;
}
Otherwise great work!
Let me know if you have any questions about the feedback.
|
|
||
| function introduceMe(name, age) | ||
| return "Hello, my name is " + name "and I am " age + "years old"; | ||
| return "Hello, my name is " + name + "and I am " + age + "years old"; |
There was a problem hiding this comment.
Suggested change
| return "Hello, my name is " + name + "and I am " + age + "years old"; | |
| { return "Hello, my name is " + name + " and I am " + age + " years old"; } |
| total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return "The total is" + total; |
There was a problem hiding this comment.
Suggested change
| return "The total is" + total; | |
| return "The total is " + total; |
| return "The total is total"; | ||
| return "The total is" + total; | ||
| } | ||
| let x = |
|
|
||
| function trimWord(word) { | ||
| return wordtrim(); | ||
| return wordtrim; |
There was a problem hiding this comment.
Suggested change
| return wordtrim; | |
| return word.trim(); |
|
|
||
| function getStringLength(word) { | ||
| return "word".length(); | ||
| return word.length(); |
There was a problem hiding this comment.
Suggested change
| return word.length(); | |
| return word.length; |
| } | ||
|
|
||
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| return "firstWord" + "secondWord" + "thirdWord"; |
There was a problem hiding this comment.
Suggested change
| return "firstWord" + "secondWord" + "thirdWord"; | |
| return `${firstWord} ${secondWord} ${thirdWord}`; |
| */ | ||
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax() { |
There was a problem hiding this comment.
Suggested change
| function calculateSalesTax() { | |
| function calculateSalesTax(sales) { |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard? extra a did't understand what is exactly required
What do you still not understand?
Any other notes?