Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Glasgow Class 5 - Andrew Robertson - JavaScript Core 1 - Week 1 - #135

Closed
Andy-Robertson wants to merge 14 commits into
CodeYourFuture:masterfrom
Andy-Robertson:master
Closed

Glasgow Class 5 - Andrew Robertson - JavaScript Core 1 - Week 1#135
Andy-Robertson wants to merge 14 commits into
CodeYourFuture:masterfrom
Andy-Robertson:master

Conversation

@Andy-Robertson

@Andy-Robertson Andy-Robertson commented Jun 28, 2021

Copy link
Copy Markdown

Your Details

  • Your Name: Andrew Robertson
  • Your City: Glasgow
  • Your Slack Name: Andy

Homework Details

  • Module: JavaScript Core 1
  • Week: 1

Notes

  • Any other notes?
    When working through the exercises and experimenting with console.log() on esercise2 of K-functions-parameters I got a NaN output when I divided 0 by 0 but when I tried the other K-function-parameters exercises using 0 the answers were all 0, so it makes me wonder why divide is different??

View rendered exercises/A-setup-ide/README.md
View rendered exercises/B-hello-world/README.md

@ibmmtr ibmmtr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work


let greeting =
". My name is Andrew and Ive been learning how to code with <Code>YourFuture since 10/04/21";
let greeting = ". Hello world";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is dot before hello world text ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback Ibrahim,

By using a for loop to create the three console log messages I was able to then use its count variable "i" to add a preceding number to each message and display,

  1. Hello world
  2. Hello world
  3. Hello world

So, the second character in the above messages is the dot before the hello world text :)

Updated const naming convention to be more distinguishable from let variables using camel case.
In several cased tweaked the comments to better explain how the program works for clarity.
Restructured some of the code with a focus on declaring and initialising variables first to improve readability.
@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label Aug 13, 2021
@github-actions github-actions Bot closed this Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants