Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

JavaScript-Core1-Week1-Niamh Madden - #131

Closed
niamhmadden23 wants to merge 13 commits into
CodeYourFuture:masterfrom
niamhmadden23:master
Closed

JavaScript-Core1-Week1-Niamh Madden #131
niamhmadden23 wants to merge 13 commits into
CodeYourFuture:masterfrom
niamhmadden23:master

Conversation

@niamhmadden23

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?


var nameLength = name.length;

console.log(nameLength)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done on getting the length of the name, you missed part of the exercise where you concatenate the string and use the trim() method 🙂


var percentageOfStudents = 15 /23 * 100;
var percentageOfMentors = 8/23*100;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, you could use the Math.round() function to round the results to whole numbers

function shoutGreeting (name){
name = name.toUpperCase();
console.log(`Hello ${name}`);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea of this exercise was to have 2 separate functions, one that returns the name in uppercase and another that returns the greeting by calling the first function to get the name

}

function introduceMe(name, age)
return "Hello, my name is " + name "and I am " age + "years old";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a syntax error on this line

total = a + b;

return "The total is total";
return `The total is $total`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing {} around total

@lannem lannem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done Niamh :)

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label Aug 18, 2021
@github-actions github-actions Bot closed this Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants